Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show label warning on Server #593

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Show label warning on Server #593

merged 5 commits into from
Feb 4, 2021

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Feb 4, 2021 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • When we added the label warning, agent labels weren't yet in server. Now they are so we should enable this component in server too. Should help reduce the questions about labels in the community slack too.

@zhen0 zhen0 changed the title reove isCloud check for server labels Show label warning on Server Feb 4, 2021
@zhen0 zhen0 marked this pull request as ready for review February 4, 2021 16:05
znicholasbrown
znicholasbrown approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@znicholasbrown znicholasbrown merged commit ce910b2 into master Feb 4, 2021
@znicholasbrown znicholasbrown deleted the server-labels branch February 4, 2021 16:52
@znicholasbrown znicholasbrown mentioned this pull request Feb 12, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhen0 @znicholasbrown