Updates, fixes, and performance improvements #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znicholasbrown
previously approved these changes
Aug 5, 2020
| @@ -77,15 +82,20 @@ export default { | |||
| server <span class="deepRed--text font-weight-medium">start</span> | |||
| </div> | |||
| </div> | |||
| <div class="text-body-1 mt-2"> | |||
| This command has many options to customize your deployment - run it with | |||
| the <kbd>-h</kbd> flag to see the documentation! | |||
There was a problem hiding this comment.
Nice, really like this addition
| @@ -1,11 +1,11 @@ | |||
| query Errors( | |||
| $heartbeat: timestamptz_comparison_exp | |||
| $updated: timestamptz_comparison_exp | |||
There was a problem hiding this comment.
haha yea! I only noticed it because I was on a particular page that was showing really old ERRORs
src/pages/Dashboard/Errors-Tile.vue
Outdated
| } | ||
| return 0 | ||
| return failures.sort((taskRunA, taskRunB) => { | ||
| if (taskRunA.updated < taskRunB.updated) { |
There was a problem hiding this comment.
I haven't checked this, but does it updated return a number or a string? That'll be important for the comparison here.
There was a problem hiding this comment.
it returns a timestamp string like "2020-03-20T04:37:06.271147+00:00"
There was a problem hiding this comment.
Ah ok I thought it might; in which case we'll want to compare the strings like this:
new Date(taskRunA.updated) < new Date(taskRunB.updated)
znicholasbrown
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note that many of these improvements are largely driven by correctly filtering by timestamp (this wasn't always occurring previously)
cc: @jlowin / @znicholasbrown