Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont install node in the deploy step #57

Merged
merged 1 commit into from
Aug 4, 2020
Merged

dont install node in the deploy step #57

merged 1 commit into from
Aug 4, 2020

Conversation

TylerWanner
Copy link
Contributor

@TylerWanner TylerWanner commented Aug 4, 2020 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

remove cruft/ fix deploy

znicholasbrown
znicholasbrown approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need node in the deploy step anymore and it's leading to some weird behavior

@znicholasbrown znicholasbrown merged commit 2c1a97c into master Aug 4, 2020
@znicholasbrown znicholasbrown deleted the fix-deploy branch August 4, 2020 18:24
@joshmeek joshmeek mentioned this pull request Oct 14, 2020
Closed
3 tasks
@stackoverfloweth stackoverfloweth mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerWanner @znicholasbrown