Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable committing vscode editor settings to the repo #53

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Disable committing vscode editor settings to the repo #53

merged 2 commits into from
Aug 4, 2020

Conversation

joshmeek
Copy link
Contributor

@joshmeek joshmeek commented Aug 4, 2020

No description provided.

znicholasbrown
znicholasbrown approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, we'll potentially re-introduce this in the future (potentially as a settings.template.json) once we've tested the config.

@znicholasbrown znicholasbrown merged commit 5b18f6a into master Aug 4, 2020
@znicholasbrown znicholasbrown deleted the gitignore branch August 4, 2020 14:47
@stackoverfloweth stackoverfloweth mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmeek @znicholasbrown