Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ordering for last 10 runs (and possible speedup?) #50

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

jlowin
Copy link
Member

@jlowin jlowin commented Aug 4, 2020

This PR corrects the sort order for the "last ten runs" visualizations when looking at flows. I think - but am not totally sure - that because the new sort order aligns with an existing index, it's also a bit faster.

@jlowin jlowin requested a review from cicdw as a code owner August 4, 2020 03:56
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, though unable to test the performance impact atm.

@znicholasbrown znicholasbrown merged commit 6a82c30 into master Aug 4, 2020
@znicholasbrown znicholasbrown deleted the last-ten-runs branch August 4, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants