Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fixed height to subnav row to fix jumping bug #476

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

whimsicallyson
Copy link
Contributor

@whimsicallyson whimsicallyson commented Nov 30, 2020

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Fixes a bug where the height of the subnav row would change (seen when triggering schedules, among others)--define a fixed height to take care of it

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znicholasbrown znicholasbrown merged commit b83c9c4 into master Dec 1, 2020
@znicholasbrown znicholasbrown deleted the bugfix-subnav-jumping branch December 1, 2020 16:59
@zhen0 zhen0 mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants