Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LogRocket from Server deployments #43

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Remove LogRocket from Server deployments #43

merged 2 commits into from
Aug 3, 2020

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Only initialize LogRocket if the base url is a Cloud deployment.

Bugfix: fixes issue were createAPIToken wasn't being blocked from LogRocket

Resolves: #37

@znicholasbrown znicholasbrown merged commit 00ea58d into master Aug 3, 2020
@znicholasbrown znicholasbrown deleted the remove-logrocket branch August 3, 2020 23:51
@stackoverfloweth stackoverfloweth mentioned this pull request Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove LogRocket from server deployments
2 participants
@znicholasbrown @cicdw