Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets popover #377

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Secrets popover #377

merged 8 commits into from
Oct 29, 2020

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Oct 24, 2020 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • Adds an info card/popover to the Secrets page which gives info about Prefect Cloud secret management and links to Hashicorp Vault

@zhen0 zhen0 changed the base branch from master to secrets October 28, 2020 01:34
@zhen0 zhen0 marked this pull request as ready for review October 28, 2020 01:38
znicholasbrown
znicholasbrown previously requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-10-28 at 11 40 22 AM

This is displaying a little oddly, probably cause of the v-list components. Could we use card-text instead and bump up the font size a little?

@zhen0 zhen0 marked this pull request as draft October 29, 2020 15:39
Base automatically changed from secrets to master October 29, 2020 19:51
@zhen0 zhen0 marked this pull request as ready for review October 29, 2020 20:18
znicholasbrown
znicholasbrown approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhen0, thanks for the changes 👍

@znicholasbrown znicholasbrown merged commit 4d212c9 into master Oct 29, 2020
@znicholasbrown znicholasbrown deleted the secrets-popover branch October 29, 2020 20:36
@znicholasbrown znicholasbrown mentioned this pull request Oct 29, 2020
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhen0 @znicholasbrown