Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple email Cloud Hooks #372

Merged
merged 12 commits into from
Nov 5, 2020
Merged

Multiple email Cloud Hooks #372

merged 12 commits into from
Nov 5, 2020

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Updates the Cloud Hooks email input rules to allow multiple comma-separated emails (the backend already allows this).

@znicholasbrown znicholasbrown added the do not merge Do Not Merge label Oct 23, 2020
@znicholasbrown
Copy link
Contributor Author

Waiting on https://github.com/PrefectHQ/cloud/pull/2806, which fixes this in Cloud

@znicholasbrown znicholasbrown removed the do not merge Do Not Merge label Nov 5, 2020
@znicholasbrown
Copy link
Contributor Author

Now that this fix is deployed in Cloud, this should be ready to merge

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great @znicholasbrown

@zhen0 zhen0 merged commit 83b124a into master Nov 5, 2020
@zhen0 zhen0 deleted the multiple-email-cloud-hooks branch November 5, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants