Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept invitations #359

Merged
merged 34 commits into from
Oct 22, 2020
Merged

Accept invitations #359

merged 34 commits into from
Oct 22, 2020

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Oct 20, 2020

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • Updates the design of the accept invitation page to match other onboarding pages
  • Closes Update the design of the AcceptInvitation Page #282
  • This page will only be shown to existing users who click on the emailed invitation link. New users will be shown invitations (where relevant) in the updated name-team page.
  • We'll do a separate PR to update routing for onboarding (the accept route should be handled already by redirect route in auth nav guard)
  • Also working on a separate PR to the docs to add information about teams and team switching in the UI

The page now looks like this:

Screen Shot 2020-10-20 at 10 32 28 PM

@zhen0 zhen0 marked this pull request as ready for review October 21, 2020 02:34
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice @zhen0! A few comments and also noticed this, which I don't think is intentional?
Oct-21-2020 11-16-13

src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
@zhen0
Copy link
Member Author

zhen0 commented Oct 21, 2020

Thanks for the comments @znicholasbrown - changes made and ready for another review.

@zhen0
Copy link
Member Author

zhen0 commented Oct 21, 2020

Short addition to the team settings docs that we link to from this page in Prefect PR 3561

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small changes, otherwise tested and LGTM @zhen0

src/pages/Onboard/Onboard-Page.vue Outdated Show resolved Hide resolved
src/router.js Outdated Show resolved Hide resolved
src/pages/Onboard/AcceptInvitationPage.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhen0 😄

@znicholasbrown znicholasbrown merged commit 83e6d96 into master Oct 22, 2020
@znicholasbrown znicholasbrown deleted the accept-invitations branch October 22, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the design of the AcceptInvitation Page
2 participants