Expose agent persistence for server users #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshmeek
requested review from
cicdw,
jlowin,
zhen0 and
znicholasbrown
as code owners
3 tasks
zhen0
previously requested changes
Sep 24, 2020
There was a problem hiding this comment.
Thanks @joshmeek! Very cool to have a new member of the UI team 😉 and it'll be great to have agents in server.
A few suggested changes but my main concern is that agent_id seems to be breaking the Flow Run page in Cloud (tried in dev and staging).
zhen0
reviewed
Sep 25, 2020
There was a problem hiding this comment.
One small suggestion then looks good to me @joshmeek. I'll let @znicholasbrown do a final review.
Co-authored-by: Jenny G <[email protected]>
|
Hm, I'm still unable to visit flow run pages with this, getting: Getting the same with both Server and Cloud (prod). Should I be testing this in a different environment? It looks like agent stuff was released with Server 4 days ago. |
|
@znicholasbrown that was a minor bug, I'm about to release the fix in one minute. |
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
This PR exposes the agents tile and page for users of server. It also improves some of the information displayed on the cards in the agent page. Submitted flow runs will now display the ID of the agent that submitted them and links back to the agent page.
The agents page will now function much better after PrefectHQ/server#95 is released.
@zhen0 @znicholasbrown Do you usually include screenshots in PRs? I can attach some if needed