User store tests #245
Merged
User store tests #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to fix agent tests
znicholasbrown
previously approved these changes
Sep 24, 2020
There was a problem hiding this comment.
A couple small comments and looks like there's a changelog conflict but otherwise LGTM @zhen0
Comment on lines
-99
to
+104
| ).tenant | ||
| )?.tenant | ||
|
|
||
| const firstTenant = | ||
| getters['memberships']?.[0] || rootGetters['tenant/tenants'] | ||
|
|
||
| if (!defaultMembershipId || rootGetters['api/isServer']) return firstTenant | ||
| getters['memberships']?.[0]?.tenant || rootGetters['tenant/tenants']?.[0] |
There was a problem hiding this comment.
Really good catches on this, hopefully this'll fix some of those edge cases with missing tenants on load.
Comment on lines
+76
to
+77
| first_name: '', | ||
| last_name: '', |
There was a problem hiding this comment.
These were missing for long enough that I think we should add a templating function for this user state. We can do that in a follow-up PR though.
Comment on lines
+62
to
+65
| store.commit('setAgents', [{ id: '12345' }]) | ||
| expect(store.getters.agents).toEqual([ | ||
| { id: '12345', secondsSinceLastQuery: 0 } | ||
| ]) |
There was a problem hiding this comment.
Does this introduce a potential race-conditional test failure? There should never be a full second between lines 61 and 63 but...
|
Merge conflict fixed @znicholasbrown - can you approve again? |
znicholasbrown
approved these changes
Sep 28, 2020
4 tasks
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR