Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way we clear the Apollo InMemoryCache #237

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Removes the stopDefaultClient and refreshDefaultClient methods, replacing them with a single clearCache method. This should remove invariant store violation errors and allow proper refetches when swapping tokens.

cc: @zhen0

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znicholasbrown znicholasbrown merged commit 3856cc2 into master Sep 18, 2020
@znicholasbrown znicholasbrown deleted the cache-reset branch September 18, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants