Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version group #236

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Show version group #236

merged 5 commits into from
Sep 22, 2020

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Sep 18, 2020

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

  • Although we are moving towards using flow group ids, version group ids still exist and are still used in important mutations such as create_flow_run. A quick search in the community slack suggests they are well used.
  • The UI currently shows only flow group ids in the flow details tile, which can be frustrating if I want to know a flow's version group id and also potentially confusing.
  • In team settings we use the term "group id" which is confusing as its unclear if it is referring to flow or version group ids.

This PR adds version group ids to the flow details tile and makes it more clear we are using version group ids in the team settings page.

@zhen0
Copy link
Member Author

zhen0 commented Sep 22, 2020

Ready for review @znicholasbrown

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants