-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance work #201
Merged
Merged
Performance work #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @znicholasbrown!
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.md
Describe this PR
Makes some changes to the barchart visualization to take browser visibility into account when performing repaints of the canvas and svg elements.
Removes
task_run
joins on the upcoming runs queries for both the dashboard and flow pages.Creates the scaffolding for a better service worker infrastructure for heavier data visualizations and eventual token refreshes.
Adds extended slots to the TileLayout (primarily for testing, we won't use these yet)
Simplifies our duration calculations by removing the reliance on
moment
and using the JavaScript native Date object instead; this should be a nice performance improvement itself since instantiating a newmoment
object for each of our timestamps is pretty heavy. Applies to the upcoming/late runs tiles, duration spans, timeline mixins, and elsewhere.Exports the cache from the
vue-apollo
plugin (also renames it to avoid confusion).