Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance work #201

Merged
merged 21 commits into from
Sep 4, 2020
Merged

Performance work #201

merged 21 commits into from
Sep 4, 2020

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Makes some changes to the barchart visualization to take browser visibility into account when performing repaints of the canvas and svg elements.

Removes task_run joins on the upcoming runs queries for both the dashboard and flow pages.

Creates the scaffolding for a better service worker infrastructure for heavier data visualizations and eventual token refreshes.

Adds extended slots to the TileLayout (primarily for testing, we won't use these yet)

Simplifies our duration calculations by removing the reliance on moment and using the JavaScript native Date object instead; this should be a nice performance improvement itself since instantiating a new moment object for each of our timestamps is pretty heavy. Applies to the upcoming/late runs tiles, duration spans, timeline mixins, and elsewhere.

Exports the cache from the vue-apollo plugin (also renames it to avoid confusion).

Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants