Add flow concurrency page #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
commented
Sep 3, 2020
| flow_concurrency_limit { | ||
| id | ||
| limit | ||
| name |
There was a problem hiding this comment.
Note to reviewer: the confusion between label and name is a consequence of how this is implemented in the backend.
znicholasbrown
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Tested and works great @cicdw - really nice addition.
This surfaced a bug related to searching for flow and task concurrency labels which I'll address in a separate PR.
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
This PR introduces a new UI screen for managing flow concurrency limits on a per-label basis. This feature is open to all Server and Cloud tenant admins.
Most of the page was co-opted from the same page for task concurrency