Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancelling state #137

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Add cancelling state #137

merged 4 commits into from
Aug 24, 2020

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Aug 24, 2020

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Adds handling for the cancelling state and shows flow runs in a cancelling state as part of flow concurrency (as Cloud considers cancelling a running state).
Closes #136

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhen0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include cancelling state in the runs in progress count and tile in the dashboard.
2 participants