Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Switch default to user from admin #1355

Merged
merged 4 commits into from
Dec 9, 2022
Merged

Enhancement: Switch default to user from admin #1355

merged 4 commits into from
Dec 9, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Dec 7, 2022 •
edited
Loading

Description

<! -- What is it meant to do? -->
Closes #1349

Linked Issues

<! -- Use a key word (e.g. closes or resolves) to close related issues -->

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

@zhen0 zhen0 marked this pull request as ready for review December 7, 2022 21:31
znicholasbrown
znicholasbrown approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhen0 zhen0 merged commit 635df5e into master Dec 9, 2022
@zhen0 zhen0 deleted the fixes-2 branch December 9, 2022 15:30
@zhen0 zhen0 mentioned this pull request Dec 15, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@stackoverfloweth stackoverfloweth Awaiting requested review from stackoverfloweth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Default role of "Add User" Panel
2 participants
@zhen0 @znicholasbrown