Bugfix: Chat launcher icon added nav bar, previous launch button hidden #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
space-age-pete
requested review from
znicholasbrown,
zhen0 and
stackoverfloweth
as code owners
znicholasbrown
requested changes
Jun 1, 2022
| @@ -108,6 +110,8 @@ export default { | |||
|
|
|||
| <HelpMenu /> | |||
|
|
|||
| <ChatLauncher /> | |||
There was a problem hiding this comment.
Suggested change
| <ChatLauncher /> | |
| <ChatLauncher v-if="isCloud" /> |
This should only be on the nav bar if we're in a Cloud context.
src/plugins/salesforceChat.js
Outdated
| @@ -15,7 +15,7 @@ export const initializeSalesforceChat = () => { | |||
| const license = store.getters['license/license'] | |||
|
|
|||
| const initESW = function(gslbBaseURL) { | |||
| window.embedded_svc.settings.displayHelpButton = true // Or false | |||
| window.embedded_svc.settings.displayHelpButton = false // Or false | |||
There was a problem hiding this comment.
Suggested change
| window.embedded_svc.settings.displayHelpButton = false // Or false | |
| window.embedded_svc.settings.displayHelpButton = false |
Probably no need for a comment here.
|
Just checking - Are all the font-awesome file changes necessary? |
|
@zhen0 - yeah those are necessary to add new icons to the project |
znicholasbrown
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The chat feature will now be launched from an icon in the navbar rather than the floating button that has been blocking the run button
Tests and performance