Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve access-denied checks #1266

Merged
merged 3 commits into from
Apr 15, 2022
Merged

Improve access-denied checks #1266

merged 3 commits into from
Apr 15, 2022

Conversation

znicholasbrown
Copy link
Contributor

Description

This PR is meant to improve the experience of SSO-gated content for users who are not issued identity tokens. It also fixes a bug where the worker was incorrectly accessing token expiration when a token was unavailable.

Linked Issues

N/A

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

@znicholasbrown znicholasbrown merged commit ab0228a into master Apr 15, 2022
@znicholasbrown znicholasbrown deleted the access-denied-checks branch April 15, 2022 19:27
@znicholasbrown znicholasbrown mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stackoverfloweth stackoverfloweth stackoverfloweth approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znicholasbrown @stackoverfloweth