add override #1258
Merged
add override #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... looks like there may be an issue with override - looking into this further npm/cli#4232 |
znicholasbrown
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<! -- What is it meant to do? -->
Force the UI to use node-fetch 2.6.7 to avoid issues with 2.6.1. - the version required as part of [email protected]
Note - I had hoped to resolve this using overrides in our npm package but that does not seem to be working - likely connected to the npm/cli issue noted below. When that issue is fixed, it might be worth revisiting to use overrides instead of force-resolution.
Linked Issues
<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Tests and performance
Releases/Changelog cuts only