Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Expose discourse links #1244

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Feature: Expose discourse links #1244

merged 3 commits into from
Feb 24, 2022

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Feb 24, 2022 •
edited
Loading

Description

This PR builds on top of #1242 by exposing links to our new Discourse in all the right places. cc: @anna-geller

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

stackoverfloweth
stackoverfloweth approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@stackoverfloweth stackoverfloweth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👍

@anna-geller
Copy link

So cool! Thanks a lot for adding that, any reference helps raise awareness and improve SEO.

image

@znicholasbrown znicholasbrown merged commit 59366a4 into master Feb 24, 2022
@znicholasbrown znicholasbrown deleted the expose-discourse branch February 24, 2022 14:45
@znicholasbrown znicholasbrown mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znicholasbrown znicholasbrown znicholasbrown approved these changes

@stackoverfloweth stackoverfloweth stackoverfloweth approved these changes

@zhen0 zhen0 Awaiting requested review from zhen0 zhen0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cicdw @anna-geller @stackoverfloweth @znicholasbrown