Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert and agent store/vuex unit tests #124

Merged
merged 9 commits into from
Aug 21, 2020
Merged

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Aug 19, 2020

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Adds unit tests for the agent and alert vuex stores.

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments @zhen0 otherwise LGTM

tests/unit/store/agent.spec.js Outdated Show resolved Hide resolved
tests/unit/store/agent.spec.js Outdated Show resolved Hide resolved
tests/unit/store/agent.spec.js Show resolved Hide resolved
tests/unit/store/alert.spec.js Show resolved Hide resolved
Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhen0, ty for the changes!

@znicholasbrown znicholasbrown merged commit 2a7ef2d into master Aug 21, 2020
@znicholasbrown znicholasbrown deleted the unit_tests-store-alert branch August 21, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants