Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Fix Skip on SetStateDialog #1235

Merged
merged 2 commits into from
Feb 17, 2022
Merged

BugFix: Fix Skip on SetStateDialog #1235

merged 2 commits into from
Feb 17, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Feb 16, 2022

Description

<! -- What is it meant to do? -->
Makes sure we skip the task run ids query when no flow run id is available.

Linked Issues

<! -- Use a key word (e.g. closes or resolves) to close related issues -->

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zhen0 👍🏻

@zhen0 zhen0 merged commit 656fbc7 into master Feb 17, 2022
@zhen0 zhen0 deleted the task-run-fix branch February 17, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants