Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Do not call unsubscribe agents if it is not a function #1225

Merged
merged 4 commits into from
Feb 15, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Feb 10, 2022

Description

<! -- What is it meant to do? -->

Prevents an error in the terminal that arises from calling unsubscribeAgents when it hasn't been set as a function. This may be a superficial fix that means we are subscribed to agent polling for longer than we need to be. I do not think the overall impact is large but would appreciate @stackoverfloweth's eyes on this to check there is nothing more nefarious.

Linked Issues

<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Closes #1216

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

@zhen0 zhen0 changed the title Unsubscrive BugFix: Do not call unsubscribe agents if it is not a function Feb 10, 2022
@stackoverfloweth
Copy link
Contributor

@zhen0 seems pretty safe to me 👍

@zhen0 zhen0 marked this pull request as ready for review February 10, 2022 13:58
@zhen0 zhen0 merged commit 8149f0a into master Feb 15, 2022
@zhen0 zhen0 deleted the unsubscrive branch February 15, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: TypeError: i.unsubscribeAgents is not a function
3 participants