BugFix: Remove v-intersect as it was causing odd behavior #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
requested review from
znicholasbrown and
stackoverfloweth
as code owners
| @@ -83,7 +83,7 @@ export default { | |||
| </script> | |||
|
|
|||
| <template> | |||
| <v-row v-intersect="{ handler: onIntersect }" no-gutters> | |||
| <v-row no-gutters> | |||
There was a problem hiding this comment.
we might as well remove the onIntersect method above as well
zhen0
changed the title
stackoverfloweth
approved these changes
Feb 15, 2022
| @@ -38,9 +38,6 @@ export default { | |||
| }, | |||
| increment() { | |||
| this.artifact++ | |||
| }, | |||
| onIntersect([entry]) { | |||
| this.$apollo.queries.artifacts.skip = !entry.isIntersecting | |||
There was a problem hiding this comment.
@stackoverfloweth you would understand the behavior this was meant to support a bit better but does removing this have performance implications? I wonder if modifying this intersection method to match the behavior of the defined skip on the query would be better instead
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<! -- What is it meant to do? -->
Stop an odd artifact loading issue:
Linked Issues
<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Closes #1160
Tests and performance
Releases/Changelog cuts only