Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Improve loading logic for automation tab on Flow Page #1223

Merged
merged 9 commits into from
Feb 15, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Feb 10, 2022

Description

<! -- What is it meant to do? -->

Linked Issues

<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Improve the loading logic for the automations tab on the flow page. This tab takes a while to load and needs two queries.
The old logic left a gap between the loading indicator connected to each query. This PR attaches the loading state connected to the filter logic to the first loading indicator instead of the second,

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

@zhen0 zhen0 marked this pull request as ready for review February 10, 2022 01:33
@zhen0 zhen0 merged commit 5528f54 into master Feb 15, 2022
@zhen0 zhen0 deleted the flow-auto-fix branch February 15, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants