Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Change the wording on the teams page to redirect users based on their license #1210

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

ThatGalNatalie
Copy link
Contributor

Description

<! -- What is it meant to do? -->
Change the wording on the teams page to redirect users based on their license

Linked Issues

<! -- Use a key word (e.g. closes or resolves) to close related issues -->
Resolves #1208

Tests and performance

  • Changes to any .js files are covered by existing tests or this PR adds new tests (if not please explain why below)
  • No new packages are added or package size and performance considerations are discussed below
  • PR Title fits our changelog format

Releases/Changelog cuts only

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request on the variable name, otherwise logic LGTM @ThatGalNatalie

src/pages/TeamSettings/Members.vue Show resolved Hide resolved
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThatGalNatalie ThatGalNatalie merged commit 7bb5a9c into master Feb 1, 2022
@ThatGalNatalie ThatGalNatalie deleted the 1208 branch February 1, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants