Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Add once to intersect on lastTenRuns #1187

Merged
merged 2 commits into from
Dec 27, 2021
Merged

BugFix: Add once to intersect on lastTenRuns #1187

merged 2 commits into from
Dec 27, 2021

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Dec 23, 2021

Only call onIntersect on mount and once intersected to enable easier scrolling through the flow table. This potentially adds more data and polling but should still remove the big initial poll of pulling everything on the page even when not visible. Based on vuetify docs here: https://vuetifyjs.com/en/api/v-intersect/#argument

Closes #1179

Copy link
Contributor

@stackoverfloweth stackoverfloweth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution

@zhen0 zhen0 merged commit cb53934 into master Dec 27, 2021
@zhen0 zhen0 deleted the lastTenRuns branch December 27, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

run history should not reload on scroll
2 participants