Admin: Add input sanitizer as default for log rocket #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
commented
Dec 23, 2021
| @@ -133,14 +133,20 @@ export default { | |||
| confirm() { | |||
| const clockType = | |||
| typeof this[this.clockToAdd] == 'string' ? 'CronClock' : 'IntervalClock' | |||
| const parameters = this.parameter != null && isValidJson(this.parameter) ? parseJson(this.parameter) : {} | |||
There was a problem hiding this comment.
No code change here. I ran code formatter and it has reformatted this section.
zhen0
requested review from
stackoverfloweth and
znicholasbrown
as code owners
Co-authored-by: Evan Sutherland <[email protected]>
Co-authored-by: Evan Sutherland <[email protected]>
stackoverfloweth
approved these changes
Dec 29, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
Adds input sanitizer so that new inputs are hidden in log rocket as default. Also adds data-public to selects and auto-complete which do not contain sensitive data.