HOTFIX: rolling back watcher change #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackoverfloweth
requested review from
zhen0 and
znicholasbrown
as code owners
| return this.show | ||
| }, | ||
| set(value) { | ||
| this.$emit('update:show', value) |
There was a problem hiding this comment.
Are any higher-level components dependent on this emitter?
There was a problem hiding this comment.
this is a rolling back to previous functionality, so no, nothing should be expecting to receive this emit. In an attempt to remove the watcher, I mistakingly assumed that the prop was always provided, so updating the prop would be a more correct way to ensure that show stays up to date. Views like the FlowConcurrency do not pass the prop, so emitting update:show has no effect
znicholasbrown
approved these changes
Dec 14, 2021
| return this.show | ||
| }, | ||
| set(value) { | ||
| this.$emit('update:show', value) |
stackoverfloweth
changed the title
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR