Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin: Update PR template #1157

Merged
merged 11 commits into from
Dec 30, 2021
Merged

Admin: Update PR template #1157

merged 11 commits into from
Dec 30, 2021

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Dec 14, 2021

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

pleek91
pleek91 previously approved these changes Dec 16, 2021
View reviewed changes
Copy link

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stackoverfloweth
stackoverfloweth previously approved these changes Dec 17, 2021
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@zhen0 zhen0 dismissed stale reviews from stackoverfloweth and pleek91 via 95fdacf December 20, 2021 20:14
@zhen0 zhen0 merged commit 1520a64 into master Dec 30, 2021
@zhen0 zhen0 deleted the pr-template branch December 30, 2021 19:01
@zhen0 zhen0 mentioned this pull request Jan 13, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatGalNatalie ThatGalNatalie ThatGalNatalie approved these changes

@pleek91 pleek91 pleek91 approved these changes

@stackoverfloweth stackoverfloweth stackoverfloweth approved these changes

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhen0 @stackoverfloweth @pleek91 @ThatGalNatalie