Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add create_flow_run system action to automations #1152

Merged
merged 8 commits into from
Jan 10, 2022

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Dec 8, 2021

Describe this PR

Closes #1140

@zanieb
Copy link
Contributor

zanieb commented Dec 8, 2021

Are you planning on exposing some of these fields?

input create_flow_run_action_config {
    "The flow group id to create a flow run for"
    flow_group_id: UUID!
    "Optional parameters to pass to the flow run"
    parameters: JSON
    "An optional amount of time to wait before starting the flow run"
    in_seconds: Int
    "An optional name for the flow run"
    run_name: String
    "An optional list of labels for the flow run"
    labels: [String]
    "An optional key to prevent duplicate runs from being created"
    idempotency_key: String
}

@zhen0
Copy link
Member Author

zhen0 commented Dec 9, 2021

Are you planning on exposing some of these fields?

input create_flow_run_action_config {
    "The flow group id to create a flow run for"
    flow_group_id: UUID!
    "Optional parameters to pass to the flow run"
    parameters: JSON
    "An optional amount of time to wait before starting the flow run"
    in_seconds: Int
    "An optional name for the flow run"
    run_name: String
    "An optional list of labels for the flow run"
    labels: [String]
    "An optional key to prevent duplicate runs from being created"
    idempotency_key: String
}

These are great options but to add them would add another level of complexity to the automations UI. For this iteration I'd like to keep it simple but I've created a new ticket (#1154) for us to consider exposing these as priorities allow.

Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhen0 zhen0 merged commit 4daf482 into master Jan 10, 2022
@zhen0 zhen0 deleted the createFlowRunAction branch January 10, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add trigger flow run automation
4 participants