Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Set min-width in titlebars to account for shorter names #1136

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Bugfix: Set min-width in titlebars to account for shorter names #1136

merged 2 commits into from
Nov 19, 2021

Conversation

ThatGalNatalie
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Sets a min-width of 10vw in the Flow, Flow Run, and Task Run titlebars to not cut off shorter names

pleek91
pleek91 previously requested changes Nov 19, 2021
View reviewed changes
Copy link

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use a css class here. That'll keep it DRY as well as keep us from binding an inline style that will never change.

src/pages/TaskRun/TaskRun.vue Outdated Show resolved Hide resolved
@ThatGalNatalie ThatGalNatalie marked this pull request as ready for review November 19, 2021 19:59
zhen0
zhen0 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ThatGalNatalie

@zhen0 zhen0 merged commit 9959038 into master Nov 19, 2021
@zhen0 zhen0 deleted the titlebar-width branch November 19, 2021 20:47
@zhen0 zhen0 mentioned this pull request Dec 14, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

@pleek91 pleek91 pleek91 left review comments

@stackoverfloweth stackoverfloweth Awaiting requested review from stackoverfloweth

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThatGalNatalie @pleek91 @zhen0