Bugfix: Check for skipped state in task run table to fix endless duration #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatGalNatalie
requested review from
zhen0 and
znicholasbrown
as code owners
pleek91
previously requested changes
Nov 19, 2021
zhen0
previously requested changes
Nov 30, 2021
src/pages/Task/TaskRunTable-Tile.vue
Outdated
| @@ -71,7 +72,11 @@ export default { | |||
| return `%${this.searchTerm}%` | |||
| } | |||
| }, | |||
| methods: {}, | |||
| methods: { | |||
| durationCalc(startTime, endTime, state) { | |||
There was a problem hiding this comment.
nit: I would import the method with this full name calculateDuration, and rather than using another name here but calling the imported method I would just make it available to the template with
methods: {
calculateDuration
}
which should work fine since the arguments do not change
| @@ -75,7 +76,11 @@ export default { | |||
| return `%${this.searchTerm}%` | |||
| } | |||
| }, | |||
| methods: {}, | |||
| methods: { | |||
| durationCalc(startTime, endTime, state) { | |||
There was a problem hiding this comment.
same suggestion here
ThatGalNatalie
dismissed
zhen0’s stale review
added method to task run details tile
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
Resolves #1110