Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Do not add 'allFlows' if a user has only one flow #1129

Merged
merged 5 commits into from
Dec 1, 2021

Conversation

zhen0
Copy link
Member

@zhen0 zhen0 commented Nov 11, 2021

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Closes #1118

As reported in #1118, if a user has only one flow, the number of selected flows will match the number of all flows when creating an automation. This fix checks for whether a user only has one flow and no longer presumes a user means "all Flows" - this should prevent new users from creating an automation that affects all their future flows.

Copy link
Contributor

@ThatGalNatalie ThatGalNatalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stackoverfloweth
Copy link
Contributor

LGTM, great addition

Screen Shot 2021-11-30 at 3 42 44 PM

@zhen0 zhen0 merged commit d0a7659 into master Dec 1, 2021
@zhen0 zhen0 deleted the one-flow-automation branch December 1, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Completed automation summaries do not reflect selected options
3 participants