Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Checks for slashes in Cron regex to set interval schedule via Cron #1123

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Bugfix: Checks for slashes in Cron regex to set interval schedule via Cron #1123

merged 9 commits into from
Nov 18, 2021

Conversation

ThatGalNatalie
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

#1093
Checks for a slash in each Cron regex

@ThatGalNatalie ThatGalNatalie linked an issue Nov 11, 2021 that may be closed by this pull request
BUG: Setting interval schedule via Cron doesn’t work from the UI #1093
Closed
5 tasks
@ThatGalNatalie ThatGalNatalie marked this pull request as ready for review November 12, 2021 22:09
zhen0
zhen0 approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ThatGalNatalie

@ThatGalNatalie ThatGalNatalie merged commit 3427a52 into master Nov 18, 2021
@ThatGalNatalie ThatGalNatalie deleted the issue-1093 branch November 18, 2021 02:24
@zhen0 zhen0 mentioned this pull request Dec 14, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Setting interval schedule via Cron doesn’t work from the UI
2 participants
@ThatGalNatalie @zhen0