tree shaking highlightjs dependency #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackoverfloweth
requested review from
zhen0 and
znicholasbrown
as code owners
zhen0
previously requested changes
Nov 3, 2021
There was a problem hiding this comment.
This looks good to me @stackoverfloweth. I also checked tutorials as I believe they also use markdown and looked fine. As she did some work of the initial work on the markdown parser I'd like to have @ThatGalNatalie take a look at this before we merge.
zhen0
previously requested changes
Nov 3, 2021
There was a problem hiding this comment.
Oh actually I do have a requested change @stackoverfloweth - can you update the changelog please? (And update to latest master!). Thanks!
stackoverfloweth
dismissed
zhen0’s stale review
suggestion should be addressed
ThatGalNatalie
previously approved these changes
Nov 3, 2021
zhen0
previously approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Also looks good to me @stackoverfloweth - but can you add the latest from master so we can merge.
stackoverfloweth
dismissed stale reviews from zhen0 and ThatGalNatalie
via
0018a7e
znicholasbrown
approved these changes
Nov 4, 2021
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
This package's use of Highlight.js was over double the size of the next biggest dependency. Removing this dependency and the 3 lines from markdownParser I was able to bring down the highlightjs bundle size from 1.3M to 77.5K!
While at first glance, I expected this to have an impact on user experience, I cannot find an instance where this change actually effected what the user sees. I confirmed the "describe" component used in a flow's readme, as well as the artifacts tab of a flow-run. Markdown entry and parsing seems uneffected by this change.