Performance: Update inputs in flow settings - parameters #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackoverfloweth
requested review from
zhen0 and
znicholasbrown
as code owners
|
I'm seeing the same issue here with type not resetting as mentioned on #1095. I think if we're going to show type we need to fully reset the type when reset is clicked. |
|
For info - I'm going to hold off on reviewing this one further until changes in #1095 are made and merged so I'm not commenting on the same things across PRs. |
zhen0
added
the
blocked
stackoverfloweth
force-pushed
the
1095/default-parameters
branch
from
2d4ba07
to
3c7a244
Compare
stackoverfloweth
removed
the
blocked
stackoverfloweth
force-pushed
the
1095/default-parameters
branch
from
3c7a244
to
ecb1559
Compare
stackoverfloweth
force-pushed
the
1095/default-parameters
branch
from
ecb1559
to
aa486f5
Compare
zhen0
changed the title
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: until #1095 is merged this will appear much larger than it actually is. Only the last commit is different