Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1095/team settings #1101

Merged
merged 10 commits into from
Nov 18, 2021
Merged

1095/team settings #1101

merged 10 commits into from
Nov 18, 2021

Conversation

stackoverfloweth
Copy link
Contributor

@stackoverfloweth stackoverfloweth commented Oct 29, 2021 •
edited
Loading

NOTE: until #1095 is merged this will appear much larger than it actually is. Only the last commit is different

zhen0
zhen0 previously requested changes Nov 3, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a stray console log in here somewhere.

Also spacing needs some tweaks -
What I see locally:
Screen Shot 2021-11-03 at 12 53 56 PM

What I see in cloud.prefect.io:
Screen Shot 2021-11-03 at 12 53 28 PM

@stackoverfloweth stackoverfloweth dismissed zhen0’s stale review November 4, 2021 13:06

issues have been addressed

zhen0
zhen0 previously requested changes Nov 13, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not had a chance to check the KV store (need to switch backend/upgrade to find a tenant with KV access). Actions sections look fine but looks like there's an issue setting secrets.

src/pages/TeamSettings/Secrets.vue Show resolved Hide resolved
src/pages/TeamSettings/Secrets.vue Show resolved Hide resolved
src/pages/TeamSettings/Actions.vue Show resolved Hide resolved
src/pages/Integrations/PagerDuty.vue Outdated Show resolved Hide resolved
@stackoverfloweth stackoverfloweth dismissed zhen0’s stale review November 16, 2021 21:39

concerns should be addressed

zhen0
zhen0 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @stackoverfloweth - LGTM!

@stackoverfloweth stackoverfloweth merged commit b05ec30 into master Nov 18, 2021
@stackoverfloweth stackoverfloweth deleted the 1095/team-settings branch November 18, 2021 17:45
@zhen0 zhen0 mentioned this pull request Dec 14, 2021
Merged
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stackoverfloweth @zhen0