Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable start run button for late flow runs #1087

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Disable start run button for late flow runs #1087

merged 7 commits into from
Oct 19, 2021

Conversation

ThatGalNatalie
Copy link
Contributor

@ThatGalNatalie ThatGalNatalie commented Oct 15, 2021 •
edited
Loading

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Should resolve #548

@ThatGalNatalie ThatGalNatalie marked this pull request as ready for review October 15, 2021 00:34
zhen0
zhen0 previously requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion for wording.

src/pages/FlowRun/Actions.vue Outdated Show resolved Hide resolved
zhen0
zhen0 previously approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ThatGalNatalie

zhen0
zhen0 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@zhen0 zhen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ThatGalNatalie

@zhen0 zhen0 merged commit 37013f4 into master Oct 19, 2021
@zhen0 zhen0 deleted the issue-548 branch October 19, 2021 14:46
@zhen0 zhen0 mentioned this pull request Nov 1, 2021
Merged
2 tasks
This was referenced Dec 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhen0 zhen0 zhen0 approved these changes

@znicholasbrown znicholasbrown Awaiting requested review from znicholasbrown znicholasbrown is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Start Run is clickable for late flow runs
2 participants
@ThatGalNatalie @zhen0