Warning that users will be locked out if not part of a team #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
previously requested changes
Oct 12, 2021
There was a problem hiding this comment.
Looks like the logic is fine here @ThatGalNatalie but I think that, given the consequences of removing all teams, the warning needs to be even stronger. If a user has only one team left, can we remove the first part of the red text warning (lines 290-293) and then show the warning in larger text - you could also use the deeper red warning color - I think called deepred?
Also - can you add a changelog update and link the related issue so that it gets closed when the PR is merged
zhen0
previously requested changes
Oct 15, 2021
zhen0
reviewed
Oct 19, 2021
zhen0
previously requested changes
Oct 19, 2021
znicholasbrown
approved these changes
Oct 20, 2021
2 tasks
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
Should resolve #978