Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add run config tab in flow run details #1047

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

gmaliar
Copy link
Contributor

@gmaliar gmaliar commented Sep 12, 2021

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

We're using a machine learning flow with multiple run configuration environment and image settings so it's hard for us to debug which image / env variables we ran in each run right now as we don't have visual access to the RunConfig object

@znicholasbrown
Copy link
Contributor

@gmaliar thanks for the PR! It looks like you'll need to add || hasRunConfig to line 91 of the flow run page details tile or this will only show up when a run also has parameters/context

@gmaliar
Copy link
Contributor Author

gmaliar commented Sep 15, 2021

Ooh good catch, I didn't notice that! 🙇
Thanks @znicholasbrown
Fixed!

Copy link
Contributor

@znicholasbrown znicholasbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gmaliar, thanks!!

@znicholasbrown znicholasbrown merged commit f934eaf into PrefectHQ:master Sep 16, 2021
@gmaliar gmaliar deleted the add-run-config-env branch September 17, 2021 09:25
@gmaliar
Copy link
Contributor Author

gmaliar commented Sep 17, 2021

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants