Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dict component to ignore null k/v pairs #1029

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

znicholasbrown
Copy link
Contributor

PR Checklist:

  • add a short description of what's changed to the top of the CHANGELOG.md
  • add/update tests (or don't, for reasons explained below)

Describe this PR

Fixes an issue where the DictInput component was sending placeholder key/value pairs as { "null": null }

Resolves: #1023

@znicholasbrown znicholasbrown added the blocked this issue is blocked by other issues/PRs/functionality (or lack thereof) label Sep 1, 2021
@zhen0
Copy link
Member

zhen0 commented Sep 2, 2021

Is this ready for review @znicholasbrown or still blocked?

@znicholasbrown znicholasbrown removed the blocked this issue is blocked by other issues/PRs/functionality (or lack thereof) label Sep 2, 2021
@znicholasbrown
Copy link
Contributor Author

Unblocked at the moment - seemed to work fine in local testing but we'll test again in a staging env to be sure.

@znicholasbrown znicholasbrown merged commit 159f853 into master Sep 2, 2021
@znicholasbrown znicholasbrown deleted the run-page-context-parameters-bugfix branch September 2, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ECSRun on Run Screen breaks if run_task_kwargs are not provided
2 participants