-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed flows card should use start_time timestamp instead of updated #1028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give a bit more info about the reasoning for the switch @znicholasbrown? My main concern is that this switch means we no longer show flows that did not actually start in the flow failures tile - if there's a storage error for example (which as a user I'd like to know about).
Example below where a flow failed within the last 24 hours because 'Failed to load and execute Flow's environment...' and is not captured in flow failures tile. (In the current tile query it is captured).
Hm that's an interesting point - the reason for the switch is that anytime a row in the database is touched (in migrations, for example), the |
Ok it looks like that's not an indexed field, so I've updated this to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @znicholasbrown - LGTM
PR Checklist:
CHANGELOG.md
Describe this PR
Switches the filter timestamp on the dashboard failed flow tile.