Fix role reset #1019
Merged
Fix role reset #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhen0
changed the title
zhen0
commented
Aug 31, 2021
| @@ -230,7 +235,6 @@ export default { | |||
| pollInterval: 10000, | |||
There was a problem hiding this comment.
I think the best fix is to move the where we set the role but could/should we also extend this poll interval? Can't remember if there was a reason we need to be polling so frequently here?
There was a problem hiding this comment.
I think we had this at 60 s previously but it was leading to some confusion when joining teams/making updates.
znicholasbrown
approved these changes
Aug 31, 2021
This was referenced Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
CHANGELOG.mdDescribe this PR
Sets the default role in created instead of on the roles apollo query to prevent the selected role resetting when the query refetches
Stops roles resetting to admin in the team member invitation dialog select
Closes #1018