Deprecate api.flows settings that are actually for flow groups
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
previously approved these changes
Sep 1, 2020
|
|
||
|
|
||
| @register_api("flows._update_flow_setting") | ||
| async def _update_flow_setting(flow_id: str, key: str, value: any) -> models.FlowGroup: |
There was a problem hiding this comment.
Not important since these are deprecated anyway, but why is this "private"?
There was a problem hiding this comment.
Historic artifact from an earlier attempt at the server API. I will update the new version in /api/flow_groups (but leave this one for compat)
cicdw
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates
api.flowsfunctions that actually modify flow group settingsChanges
Routes for enabling/disabling heartbeats, lazarus, and version locking are now available as
api.flow_groups.*routes. The oldapi.flows.*routes remain available as deprecated routes.This is because the introduction of flow groups has changed how flow settings are managed, but these routes predate the change and are in the wrong module.
Importance
Checklist
This PR:
changes/directory (if appropriate)