Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui from services CLI command #45

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Remove ui from services CLI command #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c10047
Remove UI from services CLI command
cicdw Aug 14, 2020
75cfb84
Add changelog entry
cicdw Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changes/pr45.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
breaking:
- "Remove unused UI from services CLI - [#45](https://github.com/PrefectHQ/server/pull/45)"
2 changes: 1 addition & 1 deletion src/prefect_server/cli/dev.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def services(include, exclude):
This command starts services
"""

all_services = ["graphql", "towel", "apollo", "ui"]
all_services = ["graphql", "towel", "apollo"]
if not include:
include = all_services
else:
Expand Down
27 changes: 0 additions & 27 deletions src/prefect_server/cli/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,33 +42,6 @@ def graphql():
)


@services.command()
def ui():
"""
Start the Python GraphQL server
"""
ui_path = (
os.environ.get("PREFECT_SERVER_WEB_UI_PATH") or root_dir.parent / "cloud-web-ui"
)

if not ui_path.exists():
raise RuntimeError(
"Cannot find cloud-web-ui repository path. Please set PREFECT_SERVER_WEB_UI_PATH environment variable."
)

run_proc_forever(
subprocess.Popen(
["npm", "run", "serve"],
cwd=ui_path,
env=dict(
os.environ,
VUE_APP_GRAPHQL_HTTP=f"http://localhost:{config.services.apollo.port}",
VUE_APP_GRAPHQL_WS=f"ws://localhost:{config.services.apollo.port}",
),
)
)


@services.command()
def towel():
"""
Expand Down