Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass pgpassword to towel. #316

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Don't pass pgpassword to towel. #316

merged 1 commit into from
Jan 12, 2022

Conversation

novotl
Copy link
Contributor

@novotl novotl commented Nov 23, 2021

Summary

Closes #315

Without the rest of the PG connection string ({{ include "prefect-server.postgres-connstr" . }}) the password seems useless.

Compare it for example to hasura that receives both the connection string and the password

- name: HASURA_GRAPHQL_DATABASE_URL
value: {{ include "prefect-server.postgres-connstr" . }}
- name: PGPASSWORD
valueFrom:
{{- include "prefect-server.postgres-secret-ref" . | nindent 16 }}

Importance

Checklist

This PR:

  • successfully rendering the template with helm template helm/prefect-server
  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)

WIthout the rest of the PG connection string the password seems useless.
@novotl novotl marked this pull request as ready for review November 23, 2021 18:44
@zanieb
Copy link
Contributor

zanieb commented Jan 12, 2022

Thanks for contributing!

@zanieb zanieb merged commit b0f387e into PrefectHQ:master Jan 12, 2022
@zanieb zanieb mentioned this pull request Jan 12, 2022
@novotl novotl deleted the remove-lonely-pg-password branch January 17, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lonely pgpassword in towel helm chart
2 participants