Flaky tests: tests/cli/test_server.py

[zangell44]

First check

• I added a descriptive title to this issue.
• I used the GitHub search to find a similar issue and didn't find it.
• I searched the Prefect documentation for this issue.
• I checked that this issue is related to Prefect and not one of its dependencies.

Bug summary

The following tests are flaky, 2 runs was not enough for them to pass reliably.

@pytest.mark.parametrize("command_group", ["server"])
def test_start_no_options(mock_run_process: AsyncMock, command_group: str):
    invoke_and_assert(
        [command_group, "start"],
        expected_output_contains=[
            "prefect config set PREFECT_API_URL=http://127.0.0.1:4200/api",
            "View the API reference documentation at http://127.0.0.1:4200/docs",
        ],
    )
    mock_run_process.assert_awaited_once_with(
        command=[
            sys.executable,
            "-m",
            "uvicorn",
            "--app-dir",
            f'"{prefect.__module_path__.parent}"',  # note, wrapped in double quotes
            "--factory",
            "prefect.server.api.server:create_app",
            "--host",
            "127.0.0.1",
            "--port",
            "4200",
            "--timeout-keep-alive",
            "5",
        ],
        env=ANY,
        stream_output=True,
        task_status=ANY,
    )


def test_start_with_keep_alive_from_setting(mock_run_process: AsyncMock):
    with temporary_settings({PREFECT_SERVER_API_KEEPALIVE_TIMEOUT: 100}):
        invoke_and_assert(["server", "start"])

    mock_run_process.assert_awaited_once()
    command: List[str] = mock_run_process.call_args[1]["command"]
    assert "--timeout-keep-alive" in command
    assert command[command.index("--timeout-keep-alive") + 1] == "100"


def test_start_from_cli_with_keep_alive(mock_run_process: AsyncMock):
    invoke_and_assert(
        ["server", "start", "--keep-alive-timeout", "100"],
        expected_output_contains=[
            "prefect config set PREFECT_API_URL=http://127.0.0.1:4200/api",
            "View the API reference documentation at http://127.0.0.1:4200/docs",
        ],
    )

    mock_run_process.assert_awaited_once()
    command: List[str] = mock_run_process.call_args[1]["command"]
    assert "--timeout-keep-alive" in command
    assert command[command.index("--timeout-keep-alive") + 1] == "100"

Reproduction

`pytest tests/test_server.py`

Error

FAILED tests/cli/test_server.py::test_start_no_options[server] - ValueError: signal only works in main thread
FAILED tests/cli/test_server.py::test_start_with_keep_alive_from_setting - ValueError: signal only works in main thread
FAILED tests/cli/test_server.py::test_start_from_cli_with_keep_alive - ValueError: signal only works in main thread

Versions

`main`

Additional context

No response

[serinamarie]

Closed by #11552